[0.13] Crash when picking up BP book after migrations
Posted: Sun Jul 03, 2016 9:07 pm
by siggboy
Affected version: 0.13.3
The game crashes if you try to use a blueprint book that has a blueprint in it for entities that no longer exist (because they're from a mod that you disabled and the migration removed the entities).
How to reproduce:
Create a blueprint that uses a modded entity. Use the icon for the modded entity as one of the icons for the blueprint. Mark that blueprint active in the blueprint book. Disable the mod that added the entity. Load into the map again. Pick up the blueprint book -> crash.
The blueprint that caused the crash for me did not contain the actual entity, but the icon for the entity was used in the blueprint label. So that might have caused it, or it was simply because some of the other blueprints in the book actually contained the entity.
More tests could be done, but the above sequence of actions definitely triggers the bug.
Re: [0.13] Crash when picking up BP book after migrations
Posted: Sun Jul 03, 2016 11:20 pm
by Rseding91
Do you have a crash log and or a save file that reproduces the issue?
Re: [0.13] Crash when picking up BP book after migrations
Posted: Mon Jul 04, 2016 4:32 am
by siggboy
The save file is attached (it's pretty big because the map is large; but it's just sandbox map with not much in it).
To reproduce, simply pick up the blueprint book from the toolbar and cycle to the next blueprint in the book with Shift-MWheel.
Originally I had the crash right when I picked up the BP book from the toolbelt and dragged it onto the playing area.
So what's causing the crash seems to be the ghost preview being rendered that is missing some entities that have been migrated away.
0.001 2016-07-04 06:33:45; Factorio 0.13.3 (build 22991, win64, alpha)
0.001 Operating system: Windows 7 Service Pack 1
0.001 Program arguments: "C:\Users\Sigi\Desktop\Factorio_0.13.3\bin\x64\factorio.exe" "--wait-to-close" "25004"
0.001 Read data path: C:/Users/Sigi/Desktop/Factorio_0.13.3/data
0.001 Write data path: C:/Users/Sigi/AppData/Roaming/Factorio
0.001 Binaries path: C:/Users/Sigi/Desktop/Factorio_0.13.3/bin
0.024 Graphics options: [FullScreen: true] [VSync: true] [UIScale: 100%] [MultiSampling: OFF] [Graphics quality: normal] [Video memory usage: all] [Light scale: 100%] [Screen: 255] [DXT: false]
0.026 Available display adapters: 2
0.026 [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 750 Ti {0x05, [0,0], 1920x1200, 32bit, 59Hz}
0.026 [1]: \\.\DISPLAY2 - NVIDIA GeForce GTX 750 Ti {0x01, [1920,-376], 1200x1920, 32bit, 59Hz}
0.027 Create display on adapter 0. Size 1280x720 at position [310, 222].
0.577 Initialised Direct3D:[0] NVIDIA GeForce GTX 750 Ti; driver: nvd3dumx.dll 10.18.13.6175
0.578 Video memory size (dedicated video/dedicated system/shared system/available): 1992/0/2048/4032 MB
0.605 Desktop composition is active.
0.677 Loading mod core 0.0.0 (data.lua)
0.680 Loading mod base 0.13.3 (data.lua)
0.762 Loading mod blueprint-string 3.0.1 (data.lua)
0.811 Loading mod Artifact Retexture 2.0.0 (data.lua)
0.858 Loading mod AutoTrash 0.0.56 (data.lua)
0.907 Loading mod creative-mode 0.0.1 (data.lua)
0.961 Loading mod Expanded_Robot_Tech 0.4.1 (data.lua)
1.008 Loading mod GDIW 0.13.1 (data.lua)
1.061 Loading mod K-ItemDestroyer 1.2.0 (data.lua)
1.112 Loading mod Larger Inventory 1.0.1 (data.lua)
1.159 Loading mod ModuleInserter 0.1.35 (data.lua)
1.220 Loading mod Nucular 0.2.0 (data.lua)
1.270 Loading mod SatelliteRadar 0.4.1 (data.lua)
1.321 Loading mod ScoreExtended 1.0.8 (data.lua)
1.379 Loading mod SmallFixes 0.1.2 (data.lua)
1.429 Loading mod StoneWaterWell 1.0.1 (data.lua)
1.481 Loading mod test-mode 0.13.1 (data.lua)
1.540 Loading mod TheFatController 0.4.18 (data.lua)
1.591 Loading mod TimeTools 1.0.13 (data.lua)
1.646 Loading mod usefulSpace 0.2.4 (data.lua)
1.713 Loading mod YARM 0.7.101 (data.lua)
1.765 Loading mod Crafted Artifacts 2.0.0 (data.lua)
1.818 Loading mod FARL 0.5.30 (data.lua)
1.876 Loading mod rso-mod 2.0.8 (data-updates.lua)
1.941 Loading mod test-mode 0.13.1 (data-updates.lua)
1.994 Loading mod FARL 0.5.30 (data-updates.lua)
2.050 Loading mod AutoTrash 0.0.56 (data-final-fixes.lua)
2.109 Loading mod creative-mode 0.0.1 (data-final-fixes.lua)
2.179 Loading mod GDIW 0.13.1 (data-final-fixes.lua)
2.235 Loading mod ModuleInserter 0.1.35 (data-final-fixes.lua)
2.292 Loading mod SmallFixes 0.1.2 (data-final-fixes.lua)
2.354 Loading mod test-mode 0.13.1 (data-final-fixes.lua)
2.436 Loading mod tree_collision 0.3.0 (data-final-fixes.lua)
2.496 Loading mod true-long-reach 0.1.0 (data-final-fixes.lua)
2.564 Loading mod FARL 0.5.30 (data-final-fixes.lua)
2.640 Checksum for core: 714099156
2.640 Checksum for mod base: 3065127710
2.640 Checksum for mod blueprint-string: 2370144521
2.640 Checksum for mod Research_Savr: 0
2.640 Checksum for mod Artifact Retexture: 3092765910
2.640 Checksum for mod autofill: 0
2.640 Checksum for mod AutoTrash: 4235452664
2.640 Checksum for mod creative-mode: 2880702825
2.640 Checksum for mod Expanded_Robot_Tech: 450750456
2.640 Checksum for mod GDIW: 3072887540
2.640 Checksum for mod K-ItemDestroyer: 3205696207
2.640 Checksum for mod Larger Inventory: 32563986
2.640 Checksum for mod ModuleInserter: 1669045009
2.640 Checksum for mod Nucular: 690062061
2.640 Checksum for mod rso-mod: 691269887
2.640 Checksum for mod SatelliteRadar: 1625272447
2.640 Checksum for mod ScoreExtended: 3052219186
2.640 Checksum for mod SmallFixes: 3018113363
2.640 Checksum for mod StoneWaterWell: 538038787
2.640 Checksum for mod test-mode: 878900546
2.640 Checksum for mod TheFatController: 2087045025
2.640 Checksum for mod TimeTools: 1112125769
2.640 Checksum for mod tree_collision: 3231141521
2.640 Checksum for mod true-long-reach: 354879734
2.640 Checksum for mod usefulSpace: 616306056
2.640 Checksum for mod YARM: 1471126532
2.640 Checksum for mod Crafted Artifacts: 2576711156
2.640 Checksum for mod FARL: 2863269714
3.179 Initial atlas bitmap size is 16384
3.183 Created atlas bitmap 16384x9499
3.700 Created atlas bitmap 4096x932
8.558 Sprites loaded
8.558 Convert atlas 4096x932 to: trilinear-filtering
8.727 Loading sounds...
10.157 Custom inputs active: 0
10.192 Factorio initialised
26.338 Loading map C:/Users\Sigi\AppData\Roaming\Factorio\saves\Sandbox 0.13.zip
26.751 Info Scenario.cpp:129: Map version 0.13.3-1
29.194 Checksum for script C:/Users/Sigi/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 900459546
29.201 Checksum for script __blueprint-string__/control.lua: 371292984
29.203 Checksum for script __Research_Savr__/control.lua: 3634623530
29.206 Checksum for script __autofill__/control.lua: 2194225658
29.208 Checksum for script __AutoTrash__/control.lua: 1514829976
29.210 Checksum for script __creative-mode__/control.lua: 950756494
29.211 Checksum for script __GDIW__/control.lua: 3563958983
29.212 Checksum for script __K-ItemDestroyer__/control.lua: 1243685995
29.215 Checksum for script __ModuleInserter__/control.lua: 482848618
29.216 Checksum for script __Nucular__/control.lua: 548394352
29.224 Checksum for script __rso-mod__/control.lua: 1169691728
29.225 Checksum for script __SatelliteRadar__/control.lua: 193996382
29.227 Checksum for script __ScoreExtended__/control.lua: 2688507211
29.227 Checksum for script __SmallFixes__/control.lua: 314903509
29.229 Checksum for script __StoneWaterWell__/control.lua: 4261078911
29.233 Checksum for script __test-mode__/control.lua: 1548825344
29.238 Checksum for script __TheFatController__/control.lua: 2348030623
29.240 Checksum for script __TimeTools__/control.lua: 3262350832
29.241 Checksum for script __usefulSpace__/control.lua: 3493372606
29.244 Checksum for script __YARM__/control.lua: 616803594
29.251 Checksum for script __FARL__/control.lua: 168270991
37.368 Error CrashHandler.cpp:183: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-cowk3t\libraries\stackwalker\stackwalker.cpp (906): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-cowk3t\src\util\logger.cpp (328): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-cowk3t\src\util\logger.cpp (382): Logger::logStacktrace
c:\cygwin64\tmp\factorio-cowk3t\src\util\crashhandler.cpp (84): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-cowk3t\src\util\crashhandler.cpp (186): CrashHandler::SignalHandler
d:\th\minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp (219): _seh_filter_exe
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (273): `__scrt_common_main_seh'::`1'::filt$0
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000001405C3FE0)
00000001405C3FE0 (factorio): (filename not available): __C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077A77E8D)
0000000077A77E8D (ntdll): (filename not available): RtlDecodePointer
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077A684CF)
0000000077A684CF (ntdll): (filename not available): RtlUnwindEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077A9BAC8)
0000000077A9BAC8 (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-cowk3t\src\circuitnetwork\behaviors\arithmeticcombinatorcontrolbehavior.cpp (137): ArithmeticCombinatorControlBehavior::setParameters
c:\cygwin64\tmp\factorio-cowk3t\src\blueprintentities.cpp (226): BlueprintEntities::addEntity
c:\cygwin64\tmp\factorio-cowk3t\src\blueprintentities.cpp (274): BlueprintEntities::setupEntities
c:\cygwin64\tmp\factorio-cowk3t\src\graphics\buildingrenderer.cpp (187): BuildingRenderer::drawBlueprintToBeBuilt
c:\cygwin64\tmp\factorio-cowk3t\src\graphics\buildingrenderer.cpp (163): BuildingRenderer::prepareBuildingInGame
c:\cygwin64\tmp\factorio-cowk3t\src\graphics\buildingrenderer.cpp (90): BuildingRenderer::prepare
c:\cygwin64\tmp\factorio-cowk3t\src\graphics\gamerenderer.cpp (122): GameRenderer::prepareJob
c:\cygwin64\tmp\factorio-cowk3t\src\graphics\gamerenderer.cpp (118): GameRenderer::prepare
c:\cygwin64\tmp\factorio-cowk3t\src\gameview.cpp (753): GameView::prepareRender
c:\cygwin64\tmp\factorio-cowk3t\src\mainloop.cpp (258): MainLoop::prepare
c:\cygwin64\tmp\factorio-cowk3t\src\mainloop.cpp (578): MainLoop::tickStep
c:\cygwin64\tmp\factorio-cowk3t\src\mainloop.cpp (691): MainLoop::run
c:\cygwin64\tmp\factorio-cowk3t\src\main.cpp (741): wmain
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (255): __scrt_common_main_seh
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000778459BD)
00000000778459BD (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077A7A2E1)
0000000077A7A2E1 (ntdll): (filename not available): RtlUserThreadStart
41.342 Error CrashHandler.cpp:85: Map tick at moment of crash: 5589864
41.342 Error Util.cpp:77: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.
Re: [0.13] Crash when picking up BP book after migrations
Posted: Mon Jul 04, 2016 6:56 am
by Rseding91
Can you include all the mods you're using in the save as well? When I load it without the mods it works just fine.
Re: [0.13] Crash when picking up BP book after migrations
Posted: Mon Jul 04, 2016 7:15 am
by Rseding91
Was this save originally created in 0.13.4 or did you migrate it from one of the older versions?
Re: [0.13] Crash when picking up BP book after migrations
Posted: Mon Jul 04, 2016 7:31 am
by siggboy
The save is migrated from 0.12. The blueprints were created in 0.13 by importing blueprints with Blueprint string; the imported blueprints were also created in 0.13, on a map that was migrated from 0.12.
I'm attaching an archive of the mod folder to this post.
The mod that I disabled to provoke the crash is "SmartTrains". I've also disabled "Personal Teleporter" (that must be unrelated because I've never used it).
Re: [0.13] Crash when picking up BP book after migrations