Page 1 of 1

*[0.13.3] Power switch sparks when not connected

Posted: Sun Jul 03, 2016 6:03 am
by keyboardhack
When the power switch isn't inside an electrical network it sparks when turned on as if electricity runs through it. The expected behavior would be no sparks when the power switch is turned on and there is no electrical grid or there is no power in the current electrical grid.

Steps to reproduce.
  • Place a power switch outside of an electrical grid
  • Click the switch and turn it on in the menu
  • The switch now sparks even though there is no electricity to make the sparks

Re: [0.13.3] Power switch sparks

Posted: Sun Jul 03, 2016 8:17 am
by DevilXD
Yeah, I've noticed it too, it just looks... Unnatural :) It would look better if the animation wasn't played when it isn't connected to the power network yet.

Re: [0.13.3] Power switch sparks

Posted: Sun Jul 03, 2016 10:45 am
by Loewchen
Can confirm.

Re: *[0.13.3] Power switch sparks when not connected

Posted: Sun Jul 03, 2016 11:26 am
by Rseding91
*throws hands in the air* you want *this* fixed when we've got map corruption, instant desyncs, and all kinds of other crash reports? :P

Re: *[0.13.3] Power switch sparks when not connected

Posted: Sun Jul 03, 2016 11:27 am
by DevilXD
Rseding91 wrote:*throws hands in the air* you want *this* fixed when we've got map corruption, instant desyncs, and all kinds of other crash reports? :P
I mean, when you have some spare time... :P

Re: *[0.13.3] Power switch sparks when not connected

Posted: Tue Jul 05, 2016 12:15 pm
by Loewchen
On hindsight, if the sparkling is removed when not connected to power, there is no visual indication of the state the switch is in anymore, this might be a bigger issue than the physical correctness.

Re: *[0.13.3] Power switch sparks when not connected

Posted: Tue Jul 05, 2016 12:30 pm
by kovarex
I would say, not a bug.

Re: *[0.13.3] Power switch sparks when not connected

Posted: Tue Jul 05, 2016 12:47 pm
by Twinsen
Fixed in Version: 0.13.5.

It will not show when one of the poles is not connected or when no electricity is flowing through any of the networks.
It will still show the sparks in some situations even though electricity is not technically flowing through the switch, but that is a minor issue that will not be fixed.

Re: *[0.13.3] Power switch sparks when not connected

Posted: Tue Jul 05, 2016 4:26 pm
by Dev-iL
Loewchen wrote:On hindsight, if the sparkling is removed when not connected to power, there is no visual indication of the state the switch is in anymore, this might be a bigger issue than the physical correctness.
Well, assuming the "electricity" can be removed from the animation somehow (e.g. freeze the animation of the switch on some frame that has no power [like it being stuck in the middle, half open] or just create a frame like that), your visual indication for the state would be the fact that the switch looks "not closed" :)