Page 1 of 1

[0.12.6] [kovarex] Graphical Bugs - Curved Belt

Posted: Tue Sep 08, 2015 8:45 am
by Rythe
Ran into an odd graphical glitch with curved transport belts - one row of pixels isn't rendering on one of the animation frames near the top. It looks like it's caused by a seam in the terrain as every curved belt passing that one particular line has the same glitch. This only happens at one zoom level though, which you can get if you zoom all the way in then zoom out 14 steps. I'd guess it's some half pixel weirdness.
FactorioBug1.png
FactorioBug1.png (105.88 KiB) Viewed 6862 times

Re: [0.12.6] Graphical Bugs - Boiler and Curved Belt

Posted: Tue Sep 08, 2015 10:25 am
by kovarex
Do you have the save?

Re: [0.12.6] Graphical Bugs - Boiler and Curved Belt

Posted: Tue Sep 08, 2015 7:30 pm
by Rythe
Attached a save that starts at the flickering curved belts.

The boilers don't appear to be running on load, so you'll probably have to set up a case where they're working then cut their water supply.

Re: [0.12.6] Graphical Bugs - Curved Belt

Posted: Wed Sep 09, 2015 12:19 pm
by Oxyd
Split your first post so that each bug is in its own thread.

I can't reproduce this issue. What are your graphics settings? Did you perhaps enable multisampling in config.ini?

Re: [0.12.6] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 12:41 am
by Rythe
I do not recall enabling multisampling, and I believe I had to download a full install for one of the updates as it was when the Win x64 auto patcher wasn't working, but these are probably settings carried over from version 0.10 or so, possibly 0.9. I may or may not have fiddled with multisampling way back when via in-game options, but never manually altered the config.ini myself. I do see the two multisampling entries in the graphical bit of my config.ini dump below.

multisampling=2
fullscreen=false
show-smoke=true
show-clouds=true
show-minimap=true
show-pollution-on-minimap=true
show-grid-when-paused=true
show-inserter-arrows-when-detailed-info-is-on=false
show-mining-drill-arrows-when-detailed-info-is-on=true
light-entity-info-background=false
low-graphics=false
lights-render-quality=0.200000003
preffered-screen-index=0
show-inserter-shadows=true
v-sync=true
screenshots_queue_size=10
screenshots_threads_count=1
system-ui-scale=true
custom-ui-scale=1
preferred-screen-index=255
graphics-quality=normal
video-memory-usage=all
multisampling-level=0

My video card is a Radeon R9 200 series.

Re: [0.12.6] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 1:04 am
by Rythe
And as an experiment, I changed that multisampling=2 entry to =0 and =1, completely removed the line, and ran the game at full screen at =2, but no change. Glitch still lives.

Re: [0.12.6] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 1:41 am
by Rythe
For more experiments, I turned multisampling on and it made it a more pronounced problem (along with the other lines that multisampling introduces for most people).

But that really doesn't narrow things down much, so I turned it back off and then went exploring at full zoom level. Found some more issues. I believe that some (curved and start) belt attachment pieces aren't being placed correctly with one or so animation frames. Like the animation frame itself isn't aligned the same as the other frames in the graphic files/draw buffer, but there could also be some other slight positioning issues that Radeon cards make worse to the point of being noticeable.

So more screenshots.
FactorioBelts1.png
FactorioBelts1.png (171.46 KiB) Viewed 6763 times
FactorioBelts2.png
FactorioBelts2.png (226.52 KiB) Viewed 6763 times
FactorioBelts3.png
FactorioBelts3.png (196.35 KiB) Viewed 6763 times
The last one especially shows how the shadow part of the asset isn't being positioned/filled correctly, along with the belt border line not being rendered at 100% opacity.

Re: [0.12.6] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 2:32 am
by Rythe
And since I'm poking at it, this attachment piece looks screwy too.
FactorioBelts4.png
FactorioBelts4.png (172.65 KiB) Viewed 6758 times
FactorioBelts5.png
FactorioBelts5.png (544.8 KiB) Viewed 6758 times
Shading/shadowing is off and it also looks like the piece got stretched somehow? The bottom right corner shadow is stronger than the bottom left corner shadow and the arrow isn't aligned correctly.

Edit - Oh, and for the vertical belt directly below the player character, the nose on the arrow going into the curved belt section got truncated strangely.

Re: [0.12.6] [kovarex] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 9:04 am
by kovarex
The multisampling value isn't used anymore, only the multisampling-level, we renamed it to make sure it is turned off unless people edit the config manually.

I tried the debug save, zoomed in and couldn't see any issue. I probably know how to fix it, but it would be a blind fix :)

Re: [0.12.6] [kovarex] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 9:14 am
by kovarex
So, I made a blind fix (the same we we fixed the tile gaps long time ago) for 0.12.7.

Let me know if it isn't fixed in 0.12.7 (once it is released, should be today).

Re: [0.12.6] [kovarex] Graphical Bugs - Curved Belt

Posted: Thu Sep 10, 2015 11:46 pm
by Rythe
Yep, your blind fix did the trick.

Much thanks. The flickering gap was kinda annoying to see when I was wandering around at my preferred zoom level.