Page 1 of 1

[0.12.4] Crash on Autosave (Log file)

Posted: Thu Aug 20, 2015 9:10 am
by RiotLight
Just had a crash when the game tried to auto save
log file

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Mon Aug 24, 2015 4:33 pm
by kovarex
Hmm, strange.

Can you reproduce it?
Can you provide the previous autosave?
Were you building transport belts or viewing blueprint at that time?

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Tue Aug 25, 2015 8:20 am
by boro
I also had a crash on autosave at the start of a custom map.
log file
It crashed while/after saving this file
https://www.dropbox.com/s/sjgcxkd63l9tu ... 2.zip?dl=0

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Tue Aug 25, 2015 1:19 pm
by boro
and again
log file
save: https://www.dropbox.com/s/gteqy9lsnrc0k ... 1.zip?dl=0

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Tue Aug 25, 2015 2:27 pm
by kovarex
Can you please post the mod folder?

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Tue Aug 25, 2015 2:41 pm
by boro
https://www.dropbox.com/sh/xwuofpysl9nm ... hLvfa?dl=0

I deleted an entity description file from dytech because it annoyingly increased the size of the side panel with too long descriptions, I hope that has nothing to do with this.
edit: marathon mod is deactivated.

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Tue Aug 25, 2015 4:42 pm
by kovarex
Thank you for the cooperation, I was finally able to reproduce the bug.

I found out, it is caused by the TimeButtons mod. It destroys the gui in the on_save event, which is definitelly a bad idea. So now, instead of crashing, the game shows the script error.

Removing this code should fix the problem, the mod author should probably know about it, as the mod will not be usable at all in 0.12.5 until this is removed.

Code: Select all

game.on_save (function()
	if game.player.gui.top.menu_tb ~= nil then game.player.gui.top.menu_tb.destroy() end
	if game.player.gui.top.tb_frame ~= nil then 
		game.player.gui.top.tb_frame.destroy()
	end
	
	if debug_timebuttons == 1 then game.player.print("DEBUG: SAVE AND CLEAR GUI") end
end)

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Fri Aug 28, 2015 4:24 pm
by RiotLight
kovarex wrote:Thank you for the cooperation, I was finally able to reproduce the bug.

I found out, it is caused by the TimeButtons mod. It destroys the gui in the on_save event, which is definitelly a bad idea. So now, instead of crashing, the game shows the script error.

Removing this code should fix the problem, the mod author should probably know about it, as the mod will not be usable at all in 0.12.5 until this is removed.

Code: Select all

game.on_save (function()
	if game.player.gui.top.menu_tb ~= nil then game.player.gui.top.menu_tb.destroy() end
	if game.player.gui.top.tb_frame ~= nil then 
		game.player.gui.top.tb_frame.destroy()
	end
	
	if debug_timebuttons == 1 then game.player.print("DEBUG: SAVE AND CLEAR GUI") end
end)
Just so you know Im not using the TimeButton mod.
Can you reproduce it?
Can you provide the previous autosave?
Were you building transport belts or viewing blueprint at that time?
As far as i remember i wasnt doing anything. I was watching and waiting to see which angle the biters were comming from.
I cannot provide the previous auto save as i played again shortly after my original post. It had actually saved sucessfully and i did not loose any play time. It has not happened again since.

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Fri Aug 28, 2015 4:59 pm
by kovarex
Well, it could be some other mod doing that.

Please, report it if it happens again in 0.12.5

Re: [0.12.4] Crash on Autosave (Log file)

Posted: Sat Aug 29, 2015 4:22 pm
by Ohz
kovarex wrote:Thank you for the cooperation, I was finally able to reproduce the bug.

I found out, it is caused by the TimeButtons mod. It destroys the gui in the on_save event, which is definitelly a bad idea. So now, instead of crashing, the game shows the script error.

Removing this code should fix the problem, the mod author should probably know about it, as the mod will not be usable at all in 0.12.5 until this is removed.

Code: Select all

game.on_save (function()
	if game.player.gui.top.menu_tb ~= nil then game.player.gui.top.menu_tb.destroy() end
	if game.player.gui.top.tb_frame ~= nil then 
		game.player.gui.top.tb_frame.destroy()
	end
	
	if debug_timebuttons == 1 then game.player.print("DEBUG: SAVE AND CLEAR GUI") end
end)
Well that fixed the problem for me (because the problem came from this mod).
I don't know anything about programming but you can save your mod settings on his GUI and then clear it (= destroy it), so I guess "save" is confusing (saving game, or saving mod settings? Whatever just destroy everything).