Page 1 of 1

[Klonan] [2.0.24] Modded win ending screen `Continue` unclickable off screen (and image error)

Posted: Thu Dec 05, 2024 8:37 pm
by Stringweasel
I ran into two visual bugs while trying to change Better Victory Screen to use the cool new customizable victory screen (set_win_ending_info).

What I did:
  • Add a long list of bullets.
  • No image
What I expected:
  • I expected, or at least hoped, that the bullet point list would show nicely and not causing the Continue button to be off-screen. Ideally with a scroll bar.
  • I expected using `image = nil` that the image would simply not show. I also have reason to believe this is intended behaviour.
Especially since my interface scaling settings are both unchanged at 100%.

What happened
  • The long bullet list pushed the Continue button off-screen, and now the only way to continue or quit is using Alt-F4 or clicking on the X in the top right.
  • The image is throwing an error trying to find an empty path.
Possible sollutions
Please add a scrollbar to the bullet list frame, that would be really awesome and helpful.

Reproduction

Code: Select all

/c

local p = { }
for i=1,30 do table.insert(p, "This is the "..i.."th point I'm making about something!") end
game.set_win_ending_info{
    title = "This is my title",
    image_path = nil,
    message = {"victory-message-space-age"},
    bullet_points = p,
}

game.set_game_state{player_won = true, game_finished = true, can_continue = true}
12-05-2024, 21-28-24.png
12-05-2024, 21-28-24.png (889.2 KiB) Viewed 355 times

Re: [Klonan] [2.0.24] Modded win ending screen `Continue` unclickable off screen (and image error)

Posted: Wed Jan 08, 2025 9:29 am
by Klonan
Thanks for the report,

It is fixed for 2.0.30
01-08-2025, 10-28-36.png
01-08-2025, 10-28-36.png (2.6 MiB) Viewed 250 times