Page 1 of 1

[Rseding91] [2.0.1X] Error message values shown are "off-by-one"

Posted: Thu Oct 31, 2024 12:26 am
by MrSmoothieHuman
Hello! recently, after porting and working on my mod in 2.0, i've been noticing an issue with the error messages that appear - what they show appears to be off by one. The most recent example (and what prompted this bug report) is where a subgroup that no longer exists is attached to an item, but the error message claims the subgroup belongs to the item above it?
Image
This is the example im talking about, and here is the actual code:
Image

This has only occured when using 2.0, and if i remeber correctly only past 2.0.10? however that might be off, as my memory is terrible :lol:
I'm not sure what causes this to occur, and it happens sporadicaly and not very often at that - however some things are of note:
* It seems to happen most often when i push something to this mods github repo, which could be concidence?
* The first time this happened, deleting a .zip file of the same x.x.x version seemed to have fixed the issue - but this again could have been a concidence.

I have a .zip file that can repoduce this error, however i could not include the original .zip file where this comes from due to it not uploading correctly, but which'll be included in this post :]

Re: [Rseding91] [2.0.1X] Error message values shown are "off-by-one"

Posted: Thu Oct 31, 2024 1:04 am
by Rseding91
Thanks for the report. This is now fixed for the next release.

Re: [Rseding91] [2.0.1X] Error message values shown are "off-by-one"

Posted: Thu Oct 31, 2024 10:59 am
by MrSmoothieHuman
thank you! im surprised it was able to be fixed so quickly :]

If im allowed to ask, just because it was such a random bug, what was causing it?

Re: [Rseding91] [2.0.1X] Error message values shown are "off-by-one"

Posted: Thu Oct 31, 2024 11:36 am
by Rseding91
The logic that was setting which prototype to associate was being done slightly too late for some specific values (group, subgroup specifically).

Re: [Rseding91] [2.0.1X] Error message values shown are "off-by-one"

Posted: Thu Oct 31, 2024 11:42 am
by MrSmoothieHuman
hm, neat, thank you