Page 1 of 1

[1.1.87] incorrect sound function

Posted: Fri Sep 01, 2023 7:43 pm
by Lindor
Hey :)

"__base__/prototypes/entity/sounds.lua":
function "sounds.large_explosion(volume)" has an unused "volume" parameter.

The volume is always set to 0.55 in spite of different prototypes trying to set different volumes.

Examples from "__base__/prototypes/entity/explosions.lua":

Code: Select all

(...)
  {
    type = "explosion",
    name = "big-explosion",
    (...)
    sound = sounds.large_explosion(1.0)
  },
(...)
  {
    type = "explosion",
    name = "storage-tank-explosion",
    (...)
    sound = sounds.large_explosion(0.8),
  },(...)
Implying that different volumes are a wanted feature but it's not correctly scripted.

Re: [Donion] [1.1.87] incorrect sound function

Posted: Tue Sep 05, 2023 2:31 pm
by Donion
Hi. Good catch, thanks for the report, it's now fixed for the next release.