Page 1 of 1

[boskid][1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Wed Jun 14, 2023 11:43 pm
by NotRexButCaesar
The game crashed while hosting a multiplayer game. I had just used the upgrade planner to downgrade from the map view.

Re: [1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Wed Jun 14, 2023 11:49 pm
by Loewchen
Can you reproduce this?

Re: [1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Thu Jun 15, 2023 3:27 am
by NotRexButCaesar
Loewchen wrote: Wed Jun 14, 2023 11:49 pm Can you reproduce this?
No, I cannot reproduce it.

Re: [boskid][1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Thu Jun 15, 2023 1:28 pm
by boskid
Thanks for the report. Issue is now fixed for 1.1.85.

Story behind the issue is relatively short, when fixing 106428 i backported some changes without other changes and it was possible to downgrade a ghost of assembling-machine-2 with electric-engine-unit recipe set to assembling-machine-1 which for obvious reasons cannot craft that recipe as it cannot provide pipes for that recipe, but the logic was trying to setup FluidBoxManager anyway with an invalid recipe.

Re: [boskid][1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Fri Jun 23, 2023 3:38 pm
by DerNickname01
I managed to repeat this crash on game Version 1.1.85 with these settings on the upgrade planner:
Upgrade crash.png
Upgrade crash.png (21.6 KiB) Viewed 1729 times

Re: [boskid][1.1.83] Crash downgrading with upgrade planner (FluidBoxManager check fails)

Posted: Fri Jun 23, 2023 4:57 pm
by boskid
DerNickname01 wrote: Fri Jun 23, 2023 3:38 pm I managed to repeat this crash on game Version 1.1.85 with these settings on the upgrade planner:
Upgrade crash.png
I know, its already fixed for 1.1.86. There were 2 cases and i managed to identify the wrong one (fast replace downgrade vs upgrade planner downgrade)