[1.1.47] Tips & tricks (modded) prototype error at load time

This subforum contains all the issues which we already resolved.
Post Reply
ShadowGlass
Long Handed Inserter
Long Handed Inserter
Posts: 67
Joined: Sat Aug 27, 2016 1:50 pm
Contact:

[1.1.47] Tips & tricks (modded) prototype error at load time

Post by ShadowGlass »

This error only happens on 1.1.47. It works correctly on 1.1.46.

image_2021-11-24_135959.png
image_2021-11-24_135959.png (24.76 KiB) Viewed 220 times

The data.lua is simply adding a custom tip with the "unlocked-recipe" trigger (testmod attached):

Code: Select all

data:extend(
{
	{
		type = "tips-and-tricks-item-category",
		name = "test-category",
		order = "a"
	},
	{
		type = "tips-and-tricks-item",
		name = "test-tip",
		category = "test-category",
		order = "a",
		trigger =
		{
			type = "unlocked-recipe",
			recipe = "speed-module"
		},
		is_title = true,
	}
})
There's no problem with trigger types "set-recipe" or "build-entity", but I haven't tested all possible trigger types from the wiki. I'd recommend testing all of them.
Attachments
tips-test_0.1.0.zip
(1.32 KiB) Downloaded 58 times

ShadowGlass
Long Handed Inserter
Long Handed Inserter
Posts: 67
Joined: Sat Aug 27, 2016 1:50 pm
Contact:

Re: [1.1.47] Tips & tricks (modded) prototype error at load time

Post by ShadowGlass »

So apparently this was changed to "unlock-recipe" from "unlocked-recipe". I think the bug report is still valid, as this was an undocumented change.

1. Please update the wiki. Updating the documentation should be part of the workflow, and a change/bugfix/feature shouldn't be considered "done", until the documentation is also updated.
2. This was a breaking change for mods, and was not included in the changelog. Please don't do this.

Thank you.

kovarex
Factorio Staff
Factorio Staff
Posts: 8055
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [1.1.47] Tips & tricks (modded) prototype error at load time

Post by kovarex »

Hello, thanks for the notice, I added a note to the next changelog.

User avatar
jan1i3
Long Handed Inserter
Long Handed Inserter
Posts: 51
Joined: Sun Dec 09, 2018 1:36 pm
Contact:

Re: [1.1.47] Tips & tricks (modded) prototype error at load time

Post by jan1i3 »

According to my tool there are 0 (latest 1.1 releases of) mods on the portal with `unlocked-recipe` in any of their .lua files, and I believe this to be accurate.

While I agree that keeping docs up to date is important, and adding a notice in the changelog is good as well, I am incredibly happy to see you make this kind of a change even with the potential of breaking a few mods. And in this case there happen to be no (public) broken mods making it a win-win :D
Also known as JanSharp. jan1i3 was/is my old name ;)

Bilka
Factorio Staff
Factorio Staff
Posts: 2804
Joined: Sat Aug 13, 2016 9:20 am
Contact:

Re: [1.1.47] Tips & tricks (modded) prototype error at load time

Post by Bilka »

The wiki is now also updated.
I'm an admin over at https://wiki.factorio.com. Feel free to contact me if there's anything wrong (or right) with it.

Post Reply

Return to “Resolved Problems and Bugs”